introduce CMP_RAT_CTX to hold OSSL_CMP_CTX, impl RATs#122
Conversation
DDvO
left a comment
There was a problem hiding this comment.
Please avoid extending OSSL_CMP_CTX,
as this should not be needed at all -
please keep all RAT-related data local in cmpClient().
There are various memory leaks, at least in error cases.
See also further comments in #121 (review)
|
@DDvO Hi, would it not be better to think about some sort of |
I am not sure if I fully understood what you mean, |
I was thinking about some new mechanism, to add different remote attestation logic in a shared interface, and Provider, was just a temporary name. And since you have a lot of experience with OpenSSL, I was curious about your ideas or solutions to add such a new feature. |
Motivation
see #121 , but with less modifications as proposed by @rajeev-0